-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend, net: Support compression protocol #373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #361
Problem Summary:
PacketIO
: proxy-protocol, TLS, compression, and uncompressed packets. Too many branches in one class make the code harder to maintain.What is changed and how it works:
compress.go
.PacketIO
still handles MySQL packet reading and writingcompressReadWriter
handles compression protocoltlsReadWriter
handles TLSproxyReadWriter
handles proxy-protocolbasicReadWriter
wraps the raw connection and handles basic connection features like recording the traffic, checking if the peer is aliveCheck List
Tests
Tested with:
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.